Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create accessory method for consistent tree size retrieval #160

Closed
staheri14 opened this issue Mar 27, 2023 · 0 comments · Fixed by #191
Closed

Create accessory method for consistent tree size retrieval #160

staheri14 opened this issue Mar 27, 2023 · 0 comments · Fixed by #191
Assignees
@staheri14

Comments

@staheri14
Copy link
Contributor

The current implementation of the code accesses the size of the tree by sometimes using the length of leafHashes and sometimes by using the length of the leaves field of the tree. To improve code readability and clarity, it would be beneficial to create an accessory method that consistently returns the size of the tree and use this method throughout the codebase.
@staheri14 staheri14 self-assigned this Mar 27, 2023
@staheri14 staheri14 mentioned this issue Apr 4, 2023
Closed
@staheri14 staheri14 mentioned this issue May 4, 2023
Merged
5 tasks
staheri14 added a commit that referenced this issue May 4, 2023
@staheri14
feat: adds the Size() method to the nmt API (#191)
f6e7254 
## Overview
Closes #160
## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staheri14 staheri14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adds the Size() method to the nmt API celestiaorg/nmt
1 participant
@staheri14