Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeCov is failing #250

Closed
rootulp opened this issue Apr 17, 2024 · 0 comments · Fixed by #255
Closed

CodeCov is failing #250

rootulp opened this issue Apr 17, 2024 · 0 comments · Fixed by #255

Comments

@rootulp
Copy link
Collaborator

rootulp commented Apr 17, 2024

Context

The Go CI workflow uploads code coverage to Codecov. It's currently failing: https://github.com/celestiaorg/nmt/actions/runs/8725099979/job/23937249648

Proposal

Either:

  1. Investigate the CodeCov failure and fix it
  2. Remove CodeCov integration

Separately, consider extracting CodeCov to a separate workflow because Go build shouldn't fail if uploading code coverage fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add secrets.CODECOV_TOKEN to codecov celestiaorg/nmt
1 participant
@rootulp