Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add secrets.CODECOV_TOKEN to codecov #255

Merged
merged 2 commits into from
May 16, 2024
Merged

ci: add secrets.CODECOV_TOKEN to codecov #255

merged 2 commits into from
May 16, 2024

Conversation

ramin
Copy link
Contributor

@ramin ramin commented May 14, 2024

Closes #250

Overview

@staheri14 noticed rate limiting in CI when sending data to CODECOV. This uses the org wide secret to ensure we are free from public usage/rate limiting

@ramin ramin requested review from rootulp and staheri14 May 14, 2024 10:17
@ramin
Copy link
Contributor Author

ramin commented May 14, 2024

FYI @MSevey this is still being odd, can you verify the secret is available here and i believe there might be some admin on the codecov side maybe, see: https://github.com/celestiaorg/nmt/actions/runs/9077675099/job/24943089833?pr=255#step:8:33

evan-forbes
evan-forbes previously approved these changes May 14, 2024
@rootulp
Copy link
Collaborator

rootulp commented May 14, 2024

there might be some admin on the codecov side maybe

+1 per this line maybe we need to enable the NMT in CodeCov UI so I deactivated and activated the repo.

I can't change the default branch context to main perhaps b/c we haven't had a successful CodeCov upload from main yet

Screenshot 2024-05-14 at 8 59 09 AM

staheri14
staheri14 previously approved these changes May 14, 2024
Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ramin!

@ramin ramin dismissed stale reviews from staheri14 and evan-forbes via aebead0 May 15, 2024 11:01
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (749d39b) to head (aebead0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   68.30%   66.24%   -2.06%     
==========================================
  Files           6        6              
  Lines        1325     1022     -303     
==========================================
- Hits          905      677     -228     
+ Misses        403      328      -75     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramin
Copy link
Contributor Author

ramin commented May 15, 2024

@rootulp bumped the action version to @v4 and that took care of some stuff, seems like it fails on a "test coverage regression" which I assume is maybe it comparing head to wrong primary branch? Otherwise, whatever was acting wild stopped

@staheri14
Copy link
Contributor

Does anything hinder this PR from being merged?

@rootulp
Copy link
Collaborator

rootulp commented May 16, 2024

IMO no, I didn't hit merge b/c we usually let PR authors merge their own PRs. Seems safe to merge it

@ramin ramin merged commit 2c0563a into main May 16, 2024
6 of 8 checks passed
@ramin ramin deleted the ci/ramin/codecov branch May 16, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeCov is failing
5 participants