-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add secrets.CODECOV_TOKEN to codecov #255
Conversation
FYI @MSevey this is still being odd, can you verify the secret is available here and i believe there might be some admin on the codecov side maybe, see: https://github.com/celestiaorg/nmt/actions/runs/9077675099/job/24943089833?pr=255#step:8:33 |
+1 per this line maybe we need to enable the NMT in CodeCov UI so I deactivated and activated the repo. I can't change the default branch context to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ramin!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
- Coverage 68.30% 66.24% -2.06%
==========================================
Files 6 6
Lines 1325 1022 -303
==========================================
- Hits 905 677 -228
+ Misses 403 328 -75
Partials 17 17 ☔ View full report in Codecov by Sentry. |
Does anything hinder this PR from being merged? |
IMO no, I didn't hit merge b/c we usually let PR authors merge their own PRs. Seems safe to merge it |
Closes #250
Overview
@staheri14 noticed rate limiting in CI when sending data to CODECOV. This uses the org wide secret to ensure we are free from public usage/rate limiting