feat: implement nmt methods Min/MaxNamespace #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staheri14
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
I noticed that the PR is still in draft mode, but I just wanted to leave my first review since I received the request. If you're still working on it and plan to make further updates, just let me know and I'll take another look later. But for now, everything looks good to me - LGTM!
|
Sorry this PR was still in draft b/c I was waiting for CI checks to pass before marking as ready for review. |
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 96.21% 96.23% +0.01%
==========================================
Files 6 6
Lines 423 425 +2
==========================================
+ Hits 407 409 +2
Misses 10 10
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104