Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implements input validation functions for HashNode and HashLeaf to prevent panics #113

Merged
merged 41 commits into from
Feb 28, 2023
Merged

feat: implements input validation functions for HashNode and HashLeaf to prevent panics #113

merged 41 commits into from
Feb 28, 2023

Commits on Feb 16, 2023

  1. examines the namespace of children in the HashNode

    @staheri14
    staheri14 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    622cc16 View commit details
    Browse the repository at this point in the history

  2. adds unit test for the correctness of namespace range check in the Ha… 

    …shNode
    @staheri14
    staheri14 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    ed08c84 View commit details
    Browse the repository at this point in the history

  3. removes spaces from the test titles

    @staheri14
    staheri14 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    27d3763 View commit details
    Browse the repository at this point in the history

  4. adds two intermediate variables to hold the left and right children

    @staheri14
    staheri14 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    20a2f53 View commit details
    Browse the repository at this point in the history

  5. picks more clear variable names

    @staheri14
    staheri14 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    72a99b4 View commit details
    Browse the repository at this point in the history

  6. fixes var name capitalization

    @staheri14
    staheri14 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    19d349f View commit details
    Browse the repository at this point in the history

  7. removes an invalid testcase

    @staheri14
    staheri14 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    7caa9c8 View commit details
    Browse the repository at this point in the history

  8. renames panic to wantPanic for consistency with other tests

    @staheri14
    staheri14 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    0cb2c49 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Merge branch 'master' into verify-nodes-order-in-hashnpde

    @staheri14
    staheri14 committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    64ee062 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. explains when HashNode can panic

    @staheri14
    staheri14 committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    e7415b7 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into verify-nodes-order-… 

    …in-hashnpde
    @staheri14
    staheri14 committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    5866f52 View commit details
    Browse the repository at this point in the history

  3. fixes formatting issue causing CI failure

    @staheri14
    staheri14 committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    887c86f View commit details
    Browse the repository at this point in the history

  4. fixes gofumpt complain

    @staheri14
    staheri14 committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    e81c6ca View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. implements utilities to validate nodes and leaf formats

    @staheri14
    staheri14 committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    4843cac View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. incorporates godoc

    @staheri14
    staheri14 committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    b49e3d4 View commit details
    Browse the repository at this point in the history

  2. defines error types

    @staheri14
    staheri14 committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    76e5b6c View commit details
    Browse the repository at this point in the history

  3. integrates error types in the functions return values

    @staheri14
    staheri14 committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    8b2176b View commit details
    Browse the repository at this point in the history

  4. explains the Write may return error on invalid input format

    @staheri14
    staheri14 committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    24b4d11 View commit details
    Browse the repository at this point in the history

  5. refactors the code by removing all bool returned types

    @staheri14
    staheri14 committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    d4ca909 View commit details
    Browse the repository at this point in the history

  6. add unittest for ValidateSiblingsNamespaceOrder and ValidateNodeFormat

    @staheri14
    staheri14 committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    e01cdc2 View commit details
    Browse the repository at this point in the history

  7. implements TestIsNamespacedData

    @staheri14
    staheri14 committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    aaefd57 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. call utility functions to check inputs validity in the HashNode

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    5778342 View commit details
    Browse the repository at this point in the history

  2. adds integration tests

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    68fa186 View commit details
    Browse the repository at this point in the history

  3. removes unused comments and adds documentation

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    dcc189e View commit details
    Browse the repository at this point in the history

  4. removes unused test vectors

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    4ae9d7b View commit details
    Browse the repository at this point in the history

  5. cleans up the code

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    8ce37cf View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into hashnode-error-hand… 

    …ling
    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    7800426 View commit details
    Browse the repository at this point in the history

  7. applies 80-char line length rule

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    b858657 View commit details
    Browse the repository at this point in the history

  8. deletes an unused error variable

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    9a1fa5c View commit details
    Browse the repository at this point in the history

  9. fixes IsNamespacedData description

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    eea12ac View commit details
    Browse the repository at this point in the history

  10. revises godocs

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    3c7a48e View commit details
    Browse the repository at this point in the history

  11. removes redundant siblings order check

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    f694825 View commit details
    Browse the repository at this point in the history

  12. resolves gofumpt errors

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    968cd6c View commit details
    Browse the repository at this point in the history

  13. removes error type check

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    dea79f0 View commit details
    Browse the repository at this point in the history

  14. extracts the data length once and reuses it

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    bf241f3 View commit details
    Browse the repository at this point in the history

  15. applies some clean up and enhances documentation

    @staheri14
    staheri14 committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    b717d5c View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. addresses comments

    @staheri14
    staheri14 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    b1f17fb View commit details
    Browse the repository at this point in the history

  2. fixes error message capitalization issue and a test title

    @staheri14
    staheri14 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    faf4e50 View commit details
    Browse the repository at this point in the history

  3. checks namespaced data validity and makes an explicit panic

    @staheri14
    staheri14 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    aa5a48b View commit details
    Browse the repository at this point in the history

  4. moves the data validity check up

    @staheri14
    staheri14 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    4f2141e View commit details
    Browse the repository at this point in the history

  5. checks the data after reseting the hash

    @staheri14
    staheri14 committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    177d317 View commit details
    Browse the repository at this point in the history