Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: aligns the Ignore Max Namespace description with the implementation #199

Merged
merged 3 commits into from
May 18, 2023

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented May 18, 2023

Overview

This PR brings the description of the IgnoreMaxNamespace flag in parity with the implementation.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user-facing features like CLI or documentation updates
  • Linked issues closed with keywords

@staheri14 staheri14 self-assigned this May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #199 (375e9ee) into master (23d79b4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files           5        5           
  Lines         565      565           
=======================================
  Hits          539      539           
  Misses         15       15           
  Partials       11       11           

@staheri14 staheri14 added the documentation Improvements or additions to documentation label May 18, 2023
@staheri14 staheri14 marked this pull request as ready for review May 18, 2023 18:50
@staheri14 staheri14 added this to the Mainnet milestone May 18, 2023
@staheri14 staheri14 merged commit ba0ebb8 into master May 18, 2023
@staheri14 staheri14 deleted the update-ignore-max-namespace-description branch May 18, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants