feat!: hex encode id.String() output
#202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rootulp Is the PR ready for review? It says it is in draft mode :) |
|
It is not bc this PR is failing a test here |
|
Fixed failing test via #203 |
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 95.40% 95.39% -0.01%
==========================================
Files 5 5
Lines 566 565 -1
==========================================
- Hits 540 539 -1
Misses 15 15
Partials 11 11
|
walldiss
previously approved these changes
Jun 2, 2023
staheri14
previously approved these changes
Jun 5, 2023
staheri14
previously approved these changes
Jun 6, 2023
staheri14
approved these changes
Jun 6, 2023
evan-forbes
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a breaking change that implements #201 (comment). Relevant #200