Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: incorporates tests for short absence proof verification #217

Merged
merged 24 commits into from
Jul 4, 2023

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented Jun 29, 2023

Overview

After investigating the current implementation, verified that the nmt library is capable of verifying short absence proofs. This PR contains the necessary tests to demonstrate and test this capability.

In line with #210

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@staheri14 staheri14 self-assigned this Jun 29, 2023
@staheri14 staheri14 added the enhancement New feature or request label Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #217 (1e56c61) into master (48b8f96) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files           5        5           
  Lines         601      601           
=======================================
  Hits          563      563           
  Misses         21       21           
  Partials       17       17           
Impacted Files Coverage Δ
proof.go 88.48% <ø> (ø)

@staheri14 staheri14 marked this pull request as ready for review June 29, 2023 19:14
cmwaters
cmwaters previously approved these changes Jun 30, 2023
Copy link

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really clearly written tests 👍

rootulp
rootulp previously approved these changes Jun 30, 2023
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Callum's comment, really well written and clear tests. Great work!

proof.go Outdated Show resolved Hide resolved
proof.go Outdated Show resolved Hide resolved
proof_test.go Outdated Show resolved Hide resolved
@staheri14 staheri14 dismissed stale reviews from rootulp and cmwaters via b763911 July 3, 2023 17:37
rootulp
rootulp previously approved these changes Jul 3, 2023
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

proof_test.go Outdated Show resolved Hide resolved
proof_test.go Outdated Show resolved Hide resolved
proof_test.go Outdated Show resolved Hide resolved
@staheri14 staheri14 merged commit 3693c9a into master Jul 4, 2023
6 checks passed
@staheri14 staheri14 deleted the short-absence-proof-impl branch July 4, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants