Remove panic from IntervalDigestFromBytes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
commented
Mar 12, 2021
| @@ -220,3 +220,13 @@ func nextSubtreeSize(start, end uint64) int { | |||
| } | |||
| return 1 << uint(ideal) | |||
| } | |||
|
|
|||
| // mustIntervalDigestFromBytes optimistially converts bytes to IntervalDigest or panics | |||
| func mustIntervalDigestFromBytes(idlen namespace.IDSize, bytes []byte) namespace.IntervalDigest { | |||
There was a problem hiding this comment.
Don't think we need to export this
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 95.39% 94.82% -0.58%
==========================================
Files 7 7
Lines 304 309 +5
==========================================
+ Hits 290 293 +3
- Misses 10 11 +1
- Partials 4 5 +1
Continue to review full report at Codecov.
|
liamsi
approved these changes
Mar 13, 2021
There was a problem hiding this comment.
Thanks @Wondertan 🙏🏼
Before including this change in lazyledger-core, we should tag another release.
|
@liamsi, ok will do that |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20