Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subrootpaths #49

Merged
merged 19 commits into from
Oct 21, 2021
Merged

Subrootpaths #49

merged 19 commits into from
Oct 21, 2021

Commits on Oct 13, 2021

  1. initial unoptimized subrooth paths traversal function

    @mattdf
    mattdf committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    17163c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. cleanup and optimization

    @mattdf
    mattdf committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    ad46107 View commit details
    Browse the repository at this point in the history

  2. fix mistakenly omitted preprocessed roots

    @mattdf
    mattdf committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    f54fbf6 View commit details
    Browse the repository at this point in the history

  3. make comments more helpful, and special case check clearer

    @mattdf
    mattdf committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    16b0afc View commit details
    Browse the repository at this point in the history

  4. undo error for special case check

    @mattdf
    mattdf committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    69853e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. add more comprehensive tests, fix some issues, make GetSubrootPaths r… 

    …eturn a 3d list
    @mattdf
    mattdf committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    aad7957 View commit details
    Browse the repository at this point in the history

  2. add test case for 100% coverage

    @mattdf
    mattdf committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    814ffd8 View commit details
    Browse the repository at this point in the history

  3. change to table tests, assign named errors

    @mattdf
    mattdf committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    cfbc330 View commit details
    Browse the repository at this point in the history

  4. replace recursive subdivide with bitwise extraction

    @mattdf
    mattdf committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    0d43a25 View commit details
    Browse the repository at this point in the history

  5. generalize prune function and fix edge case, add test

    @mattdf
    mattdf committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    1654b4f View commit details
    Browse the repository at this point in the history

  6. clean up comments, add clarifying comment on new case

    @mattdf
    mattdf committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    80b59c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. more idiomatic errors 

    Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
    @mattdf @liamsi
    mattdf and liamsi committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    94c4501 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. better test descriptions, lowercase errors, add entire-square test

    @mattdf
    mattdf committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    ea05d60 View commit details
    Browse the repository at this point in the history

  2. add infinite loop bug in case of submitting a span for last two rows

    @mattdf
    mattdf committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    47048c5 View commit details
    Browse the repository at this point in the history

  3. remove trailing debug statement

    @mattdf
    mattdf committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    3acd307 View commit details
    Browse the repository at this point in the history

  4. significantly simplify implementation, use cleaner code

    @mattdf
    mattdf committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    9c8ffd4 View commit details
    Browse the repository at this point in the history

  5. remove ineffectual assign to pass go lint

    @mattdf
    mattdf committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    bd1b671 View commit details
    Browse the repository at this point in the history

  6. final cleanup

    @mattdf
    mattdf committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    f67f8cd View commit details
    Browse the repository at this point in the history

  7. add fixes suggested by john

    @mattdf
    mattdf committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    fee9337 View commit details
    Browse the repository at this point in the history