This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
test: add EVM signature methods tests #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulghangas
reviewed
Feb 9, 2023
|
|
||
| func TestSigToVRS(t *testing.T) { | ||
| sig := "0xca2aa01f5b32722238e8f45356878e2cfbdc7c3335fbbf4e1dc3dfc53465e3e137103769d6956414014ae340cc4cb97384b2980eea47942f135931865471031a00" | ||
| v, r, s := evm.SigToVRS(sig) |
There was a problem hiding this comment.
SigToVRS can potentially give invalid values. Since an invalid signature can be passed in, maybe we need to refactor this function to return an error
There was a problem hiding this comment.
It expects the signature to be valid as a precondition, But we could make it better, created issue: #105
Co-authored-by: Rahul Ghangas <rahulghangas0@gmail.com>
rahulghangas
approved these changes
Feb 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes: #53
Checklist