This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
feat: implement p2p querier #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on: #110 |
evan-forbes
reviewed
Feb 10, 2023
Comment on lines
+176
to
+177
| // TODO: make the timeout configurable | ||
| time.Sleep(10 * time.Second) |
There was a problem hiding this comment.
Just to keep a delay between the different calls to querying 2/3. I wanna change it with a ticker, what do you think? every 10sec
There was a problem hiding this comment.
I see, a ticker could be more explicit yeah, but can certainly be done outside of this PR and not the highest priority as you've indicated
evan-forbes
previously approved these changes
Feb 10, 2023
# Conflicts: # relayer/relayer.go
|
@evan-forbes Can you re-approve please? just resolved the conflicts |
evan-forbes
approved these changes
Feb 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #90
Contributes to: #108
Checklist