Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

feat: reduce the routing table refresh period #140

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Feb 15, 2023

Overview

Reduces the routing table refresh period to a more realistic period. The value is taken from Celestia-node repo.

For IPFS, the value is 10 minutes:

To keep the routing tables accurate and up to date, IPFS refreshes the routing table every 10 minutes. While this is likely a higher frequency than is strictly necessary, it's important to protect the network's health as IPFS learns more about the dynamics of the DHT network. A routing table refresh works as follows:

source: https://docs.ipfs.tech/concepts/dht/#routing-tables

I guess 1 minute is a good value given that our P2P network is still new and experimental.
We can reduce that to even 1 hour once we have enough validators running orchestrators.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added the p2p p2p network related label Feb 15, 2023
@rach-id rach-id requested a review from rahulghangas February 15, 2023 11:07
@rach-id rach-id self-assigned this Feb 15, 2023
@rach-id rach-id requested a review from evan-forbes as a code owner February 15, 2023 11:07
@codecov-commenter
Copy link

Codecov Report

Merging #140 (b0a8941) into main (27f6375) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   45.90%   45.90%           
=======================================
  Files          15       15           
  Lines         952      952           
=======================================
  Hits          437      437           
  Misses        466      466           
  Partials       49       49           
Impacted Files Coverage Δ
p2p/dht.go 61.81% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rach-id rach-id merged commit ae38ee2 into celestiaorg:main Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2p p2p network related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants