feat: support passing bootstrappers to DHT #142
Conversation
# Conflicts: # p2p/dht.go # p2p/dht_test.go # testing/dht_network.go
|
This one is next to be reviewed to unblock the other ones |
Codecov Report
@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 51.66% 48.74% -2.93%
==========================================
Files 16 17 +1
Lines 991 1155 +164
==========================================
+ Hits 512 563 +51
- Misses 423 528 +105
- Partials 56 64 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| ) | ||
|
|
||
| // give some time for the routing table to be updated | ||
| time.Sleep(time.Second) |
There was a problem hiding this comment.
Maybe we should add a timeout with busy polling or checks at intervals rather than just wait for a period of time. If this time duration is changed in the future, the test could easily become flaky on CI
There was a problem hiding this comment.
We have the wait for peers that does exactly that and its used in other tests.
However, i wanted this test to be as simple as possible and not use any such function.
What do you think? Should i open a follow up PR using that?
Overview
Contributes to #138
Checklist