Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

feat: add orchestrator command #150

Merged
merged 4 commits into from
Feb 20, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Feb 16, 2023

Overview

Closes: #47

Depends on the other PRs to be merged.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added the orchestrator orchestrator related label Feb 16, 2023
@rach-id rach-id requested a review from rahulghangas February 16, 2023 11:51
@rach-id rach-id self-assigned this Feb 16, 2023
@rach-id rach-id requested a review from evan-forbes as a code owner February 16, 2023 11:51
Copy link
Contributor

@rahulghangas rahulghangas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass looks good, will do one more before approving

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #150 (ae7729e) into main (dc40f9b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   48.74%   48.74%           
=======================================
  Files          17       17           
  Lines        1155     1155           
=======================================
  Hits          563      563           
  Misses        528      528           
  Partials       64       64           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cmd/qgb/orchestrator/cmd.go Outdated Show resolved Hide resolved
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rach-id rach-id merged commit 7559102 into celestiaorg:main Feb 20, 2023
@rach-id rach-id deleted the add_orchestrator_command branch February 20, 2023 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
orchestrator orchestrator related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the QGB orchestrator command
4 participants