Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

feat: add support for p2p listen address and identity #161

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Feb 20, 2023

Overview

Closes #149 and #156

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added the p2p p2p network related label Feb 20, 2023
@rach-id rach-id requested a review from rahulghangas February 20, 2023 16:18
@rach-id rach-id self-assigned this Feb 20, 2023
@rach-id rach-id requested a review from evan-forbes as a code owner February 20, 2023 16:18
@rach-id rach-id linked an issue Feb 20, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #161 (adb49a3) into main (7476e7e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   48.74%   48.74%           
=======================================
  Files          17       17           
  Lines        1155     1155           
=======================================
  Hits          563      563           
  Misses        528      528           
  Partials       64       64           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment on lines -16 to +27
privateKeyFlag = "eth-priv-key"
evmChainIDFlag = "evm-chain-id"
celesGRPCFlag = "celes-grpc"
tendermintRPCFlag = "celes-http-rpc"
evmRPCFlag = "evm-rpc"
contractAddressFlag = "contract-address"
evmGasLimitFlag = "evm-gas-limit"
bootstrappersFlag = "bootstrappers"
privateKeyFlag = "eth-priv-key"
evmChainIDFlag = "evm-chain-id"
celesGRPCFlag = "celes-grpc"
tendermintRPCFlag = "celes-http-rpc"
evmRPCFlag = "evm-rpc"
contractAddressFlag = "contract-address"
evmGasLimitFlag = "evm-gas-limit"
bootstrappersFlag = "bootstrappers"
p2pListenAddressFlag = "p2p-listen-addr"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated non-blocking question, do we support a config file yet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope #176

@rach-id rach-id mentioned this pull request Feb 22, 2023
@rach-id rach-id merged commit 4bb493b into celestiaorg:main Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2p p2p network related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support passing a private key when creating the P2P host Support custom listening addresses
3 participants