Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

chore: show the default home directory in --help #319

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Apr 26, 2023

Overview

Closes #270

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id requested a review from evan-forbes as a code owner April 26, 2023 11:57
@rach-id rach-id self-assigned this Apr 26, 2023
@rach-id rach-id changed the title chore: show the default home directory in --help chore: show the default home directory in --help Apr 26, 2023
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only non-blocking comments

@@ -102,7 +106,11 @@ func parseOrchestratorFlags(cmd *cobra.Command) (StartConfig, error) {
}

func addInitFlags(cmd *cobra.Command) *cobra.Command {
cmd.Flags().String(base.FlagHome, "", "The qgb orchestrator home directory")
homeDir, err := base.DefaultServicePath("orchestrator")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[not blocking]
we're using "orchestrator" twice here, so we might want to consider using a constant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -38,7 +38,11 @@ func addRelayerStartFlags(cmd *cobra.Command) *cobra.Command {
cmd.Flags().StringP(FlagBootstrappers, "b", "", "Comma-separated multiaddresses of p2p peers to connect to")
cmd.Flags().StringP(FlagP2PNickname, "p", "", "Nickname of the p2p private key to use (if not provided, an existing one from the p2p store or a newly generated one will be used)")
cmd.Flags().StringP(FlagP2PListenAddress, "q", "/ip4/127.0.0.1/tcp/30000", "MultiAddr for the p2p peer to listen on")
cmd.Flags().String(base.FlagHome, "", "The qgb relayer home directory")
homeDir, err := base.DefaultServicePath("relayer")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as other comment

@rach-id rach-id merged commit 6c60139 into celestiaorg:main Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display EVM keystore default directory
2 participants