This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
chore: replace string with constant in homeDir #329
Merged
rach-id
merged 4 commits into
celestiaorg:main
from
DeepYV:chore/update-servicename-with-constant
Apr 28, 2023
Merged
chore: replace string with constant in homeDir #329
rach-id
merged 4 commits into
celestiaorg:main
from
DeepYV:chore/update-servicename-with-constant
Apr 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
reviewed
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this 👍 👍
Maybe we could do the same for the "orchestrator"
and "deployer"
strings so this PR contains all that
sure @sweexordious. Its Done. Please review and let me know :) |
Awesome 👍 orchestrator-relayer/cmd/qgb/deploy/cmd.go Line 127 in 97a90b5
|
Sure @sweexordious done :) |
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
=======================================
Coverage 43.76% 43.76%
=======================================
Files 26 26
Lines 1990 1990
=======================================
Hits 871 871
Misses 998 998
Partials 121 121 |
rach-id
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Checklist