Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

chore: replace string with constant in homeDir #329

Merged

Conversation

DeepYV
Copy link
Contributor

@DeepYV DeepYV commented Apr 27, 2023

Overview

  1. open isssue.
  2. homeDir servic-name "relayer" was used as a string in cmd and config. Replaced with constant.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this 👍 👍

Maybe we could do the same for the "orchestrator" and "deployer" strings so this PR contains all that

@DeepYV
Copy link
Contributor Author

DeepYV commented Apr 27, 2023

sure @sweexordious. Its Done. Please review and let me know :)

@rach-id
Copy link
Member

rach-id commented Apr 27, 2023

Awesome 👍
Could you do it please also for the deployer? Example:

command.AddCommand(keys.Command("deployer"))

@DeepYV
Copy link
Contributor Author

DeepYV commented Apr 27, 2023

Sure @sweexordious done :)

@codecov-commenter
Copy link

Codecov Report

Merging #329 (1c76039) into main (50a67ac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   43.76%   43.76%           
=======================================
  Files          26       26           
  Lines        1990     1990           
=======================================
  Hits          871      871           
  Misses        998      998           
  Partials      121      121           

Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@rach-id rach-id merged commit 9ee171d into celestiaorg:main Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants