Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

fix!: dirty hack to signing successfully the first data commitment range #340

Merged

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented May 4, 2023

Overview

This is because we included the latest core release in the app v0.13.2 without including the corresponding change in the state machine.

For BSR, this case will never be hit since we will stop at the last unbonding height. But, I think it's better if we have the E2E passing to be more sure this is working.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added bug Something isn't working orchestrator orchestrator related labels May 4, 2023
@rach-id rach-id requested a review from evan-forbes as a code owner May 4, 2023 18:58
@rach-id rach-id self-assigned this May 4, 2023
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, can we have an issue to revert this eventually too? thanks!

@rach-id
Copy link
Member Author

rach-id commented May 4, 2023

This will be only for this release... won't be merged to main. So I guess no need for an issue. What do you think? @evan-forbes

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v0.2.0-app-v0.13.2-beta@765ef7d). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             v0.2.0-app-v0.13.2-beta     #340   +/-   ##
==========================================================
  Coverage                           ?   43.57%           
==========================================================
  Files                              ?       26           
  Lines                              ?     1999           
  Branches                           ?        0           
==========================================================
  Hits                               ?      871           
  Misses                             ?     1005           
  Partials                           ?      123           

@rach-id rach-id merged commit efeed21 into celestiaorg:v0.2.0-app-v0.13.2-beta May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working orchestrator orchestrator related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants