Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

Sysrex bootstrappers #346

Merged
merged 6 commits into from
May 8, 2023
Merged

Sysrex bootstrappers #346

merged 6 commits into from
May 8, 2023

Conversation

sysrex
Copy link
Contributor

@sysrex sysrex commented May 8, 2023

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@sysrex sysrex requested review from evan-forbes and rach-id as code owners May 8, 2023 18:29
rach-id
rach-id reviewed May 8, 2023
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

Dockerfile Outdated Show resolved Hide resolved
docker/entrypoint.sh Outdated Show resolved Hide resolved
Dockerfile
# stage 2
FROM alpine:3.17.3
# final image
FROM alpine:3.17.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep 3.17.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, this is the one present in the e2e Dockerfile that's why I kept it, I don't have strong considerations around minor versions in alpine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's leave it for now then, it's cool

sysrex and others added 2 commits May 8, 2023 19:35
@sysrex @rach-id
Update Dockerfile
21ede25 
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
@sysrex @rach-id
Update docker/entrypoint.sh
382d527 
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
@rach-id rach-id merged commit 97bacec into main May 8, 2023
@rach-id rach-id deleted the sysrex_bootstrappers branch May 8, 2023 18:39
rach-id pushed a commit that referenced this pull request May 8, 2023
@sysrex @rach-id
Sysrex bootstrappers (#346)
cb318e9 
* create bootstrappers

* change the way we build to allign with the node structure

* update the Dockerfile in the root repo as well

* remove duplication

* Update Dockerfile

Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>

* Update docker/entrypoint.sh

Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>

---------

Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
(cherry picked from commit 97bacec)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rach-id rach-id rach-id approved these changes

@evan-forbes evan-forbes Awaiting requested review from evan-forbes evan-forbes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sysrex @rach-id