Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

Copy the EVM related code from Celestia-app #38

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Copy the EVM related code from Celestia-app #38

merged 2 commits into from
Jan 16, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Nov 30, 2022 •
edited
Loading

Overview

Closes #14

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id changed the title Copy the related code Copy the EVM related code from Celestia-app Nov 30, 2022
@rach-id rach-id self-assigned this Nov 30, 2022
@rach-id rach-id added enhancement New feature or request orchestrator orchestrator related relayer relayer related labels Nov 30, 2022
@rach-id rach-id requested a review from evan-forbes November 30, 2022 14:52
@rach-id rach-id requested a review from rahulghangas January 2, 2023 12:56
evan-forbes
evan-forbes approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we not have any tests?

@rach-id rach-id mentioned this pull request Jan 3, 2023
Closed
@rach-id
Copy link
Member Author

rach-id commented Jan 3, 2023

We have a few tests for this, but not that good of a coverage as we were relying on the E2E mainly to spot bugs. Created an issue #53, thanks a lot

@rach-id rach-id merged commit 5bf73a0 into celestiaorg:main Jan 16, 2023
@rach-id rach-id deleted the add_evm_code branch January 16, 2023 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evan-forbes evan-forbes evan-forbes approved these changes

@rahulghangas rahulghangas Awaiting requested review from rahulghangas

Assignees

@rach-id rach-id

Labels
enhancement New feature or request orchestrator orchestrator related relayer relayer related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy the EVM transaction code from Celestia-app
2 participants
@rach-id @evan-forbes