Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

Add attestation confirms types #39

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Nov 30, 2022

Overview

Closes #21

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id requested a review from evan-forbes November 30, 2022 22:41
@rach-id rach-id self-assigned this Nov 30, 2022
@rach-id rach-id requested a review from rahulghangas January 2, 2023 12:56
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add an issue to add some basic unit tests or add them here

@rach-id
Copy link
Member Author

rach-id commented Jan 3, 2023

Thanks a lot, created #52

@rach-id rach-id merged commit 3506545 into celestiaorg:main Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the DataCommitmentConfirm and ValsetConfirm message types
2 participants