Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

feat: make the relayer save the relayed signatures to store #431

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Aug 9, 2023

Overview

Closes #369

Refactors a bit the orchestrator/relayer initialization to be able to specify different store options.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added relayer relayer related store labels Aug 9, 2023
@rach-id rach-id requested a review from evan-forbes as a code owner August 9, 2023 10:40
@rach-id rach-id self-assigned this Aug 9, 2023
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this just refactoring the stores, or is this actually storing the signatures? if we are storing the signatures, do you mind pointing out the tests? If we are not, can we rename this PR slightly to reflect that? thanks!

@evan-forbes
Copy link
Member

otherwise LGTM

@rach-id
Copy link
Member Author

rach-id commented Aug 9, 2023

is this just refactoring the stores, or is this actually storing the signatures? if we are storing the signatures, do you mind pointing out the tests?

It refactors a bit + stores the signatures. You can find the tests here:

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks

@rach-id rach-id merged commit 6434f48 into celestiaorg:main Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
relayer relayer related store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relayer saving the signatures
2 participants