-
Notifications
You must be signed in to change notification settings - Fork 16
chore: adaptations to dockerFile. Bumping ci workflow version #462
Conversation
ARG UID=10001 | ||
ARG USER_NAME=celestia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, we are aligning all DockerFiles into 1 style like we have in app and node, where there is a celestia user and not root anymore. Let me know if this is fine for the orchestrator-relayer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure :D Thanks
curl \ | ||
jq \ | ||
# Creates a user with $UID and $GID=$UID | ||
&& adduser ${USER_NAME} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be failing in docker CI:
93 Usage: adduser [OPTIONS] USER [GROUP]
#10 1.493
#10 1.493 Create new user, or add USER to GROUP
#10 1.493
#10 1.493 -h DIR Home directory
#10 1.493 -g GECOS GECOS field
#10 1.493 -s SHELL Login shell
#10 1.493 -G GRP Group
#10 1.493 -S Create a system user
#10 1.493 -D Don't assign a password
#10 1.493 -H Don't create home directory
#10 1.493 -u UID User id
#10 1.493 -k SKEL Skeleton directory (/etc/skel)
#10 ERROR: process "/bin/sh -c apk update && apk add --no-cache bash curl jq && adduser ${USER_NAME} -D -g ${USER_NAME} -h ${CELESTIA_HOME} -s /sbin/nologin -u ${UID}" did not complete successfully: exit code: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review ❤️
I totally forgot to point the home directory actually....
ARG UID=10001 | ||
ARG USER_NAME=celestia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure :D Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK.
Thanks a lot for handling this. This PR can be merged after this one is merged: #459
I've reverted for the time being back to 1.20 due to quic incompat with 1.21 in current main head |
Sure, let's keep it to v1.21 and I'll ping you when that gets merged |
@Bidon15 this is ready, once the conflicts are resolved 🙏 |
@Bidon15 Sorry, i went and resolved the conflicts so that I can release today. Let me know if I missed something |
no worries. It looks good! Thanks for driving it home! You 🪨 |
Overview
Checklist