Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

chore: .PHONY targets for Make commands #598

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Nov 17, 2023

Add .PHONY targets for all Make commands. In a Makefile, the .PHONY target is used to specify that certain targets are 'phony' and not file names.

Summary by CodeRabbit

  • Chores
    • Updated the Makefile to improve the build process with new targets for installation, dependency verification, pre-build actions, and comprehensive testing.
  • Refactor
    • Streamlined dependency checks by replacing the previous method with a mod-verify target.
  • New Features
    • Introduced a pre-build step to automatically fetch the latest git tags before building.

Copy link
Contributor

coderabbitai bot commented Nov 17, 2023

Walkthrough

The Makefile has been updated to enhance the build process for a Go project. Key improvements include the addition of .PHONY targets to ensure make commands are run properly, a shift from checking go.sum directly to using mod-verify for dependency verification, the introduction of a pre-build step to fetch the latest git tags, and a new test-all target to facilitate comprehensive testing.

Changes

File Change Summary
Makefile - Added .PHONY targets for various build steps.
- Replaced direct go.sum check with mod-verify.
- Included pre-build step for git tags.
- Added test-all target.

🐇 In the fall, as leaves descend,
Our Makefile's got a brand new trend.
With targets fresh and checks so spry,
We code, we build, under the November sky. 🍂✨


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 17b5716 and 760792f.
Files selected for processing (1)
  • Makefile (2 hunks)
Files skipped from review due to trivial changes (1)
  • Makefile

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17b5716) 26.13% compared to head (760792f) 26.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   26.13%   26.13%           
=======================================
  Files          29       29           
  Lines        3019     3019           
=======================================
  Hits          789      789           
  Misses       2135     2135           
  Partials       95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rootulp rootulp self-assigned this Nov 17, 2023
@rootulp rootulp added the chore label Nov 17, 2023
@rach-id rach-id merged commit c85b3b2 into celestiaorg:main Nov 17, 2023
18 of 19 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants