Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

chore: rename residual QGB mentions to Blobstream #622

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Nov 26, 2023

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • Refactor

    • Updated terminology from "QGB" to "Blobstream" across various components and test suites.
    • Changed directory and import paths to reflect the new Blobstream naming convention.
    • Modified log messages to align with the rebranding to Blobstream.
  • Tests

    • Adjusted test import paths and function calls to use the new blobstreamtesting package.
  • Chores

    • Renamed chain ID in testing configuration to "blobstream-test" for consistency with the new naming scheme.

@rach-id rach-id added the chore label Nov 26, 2023
@rach-id rach-id self-assigned this Nov 26, 2023
@rach-id rach-id requested a review from evan-forbes as a code owner November 26, 2023 22:41
Copy link
Contributor

coderabbitai bot commented Nov 26, 2023

Walkthrough

The changes across various Go files reflect a rebranding or refactoring effort, where references to "QGB" are being replaced with "Blobstream". This includes updates to log messages, directory names, import paths, and chain IDs. The modifications are textual and do not alter the core functionality or structure of the codebase.

Changes

File(s) Change Summary
benchmark/main.go Renamed directory in os.MkdirTemp and updated log messages from "QGB" to "Blobstream".
evm/evm_client.go Updated log messages from "QGB" to "Blobstream" for contract deployment.
orchestrator/orchestrator_test.go
relayer/relayer_test.go
Changed import paths and function calls from .../testing to .../testing/blobstreamtesting and updated related function calls.
store/init.go Updated log messages within Init function from "qgb store" to "Blobstream store".
testing/celestia_network.go Changed chain ID from "qgb-test" to "blobstream-test".

🐇✨
In the realm of code where the data streams flow,
A rabbit hopped through, with changes in tow.
"Farewell to QGB," it cheerfully streamed,
"Hello Blobstream," it joyfully beamed. 🎉
✨🐇


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 33f7618 and b0ed9aa.
Files selected for processing (6)
  • benchmark/main.go (2 hunks)
  • evm/evm_client.go (2 hunks)
  • orchestrator/orchestrator_test.go (3 hunks)
  • relayer/relayer_test.go (4 hunks)
  • store/init.go (2 hunks)
  • testing/celestia_network.go (1 hunks)
Files skipped from review due to trivial changes (5)
  • benchmark/main.go
  • evm/evm_client.go
  • orchestrator/orchestrator_test.go
  • relayer/relayer_test.go
  • store/init.go
Additional comments: 2
testing/celestia_network.go (2)
  • 91-94: The change in chain ID from "qgb-test" to "blobstream-test" is consistent with the pull request's objective to rename QGB to Blobstream. Ensure that all references and dependencies throughout the codebase that rely on the chain ID are updated accordingly.

  • 91-97: > Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [7-7]

The import path github.com/celestiaorg/celestia-app/x/qgb/types should be updated to reflect the new naming convention if the module has been renamed accordingly. Verify that the module path is correct and update if necessary.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33f7618) 26.13% compared to head (b0ed9aa) 26.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #622   +/-   ##
=======================================
  Coverage   26.13%   26.13%           
=======================================
  Files          29       29           
  Lines        3019     3019           
=======================================
  Hits          789      789           
  Misses       2135     2135           
  Partials       95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rach-id rach-id merged commit 010a6aa into celestiaorg:main Nov 27, 2023
18 of 19 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants