feat: add moniker and valoper address to signatures query #627
Conversation
rach-id
added
enhancement
WalkthroughThe codebase has been updated to enhance the functionality related to validators. New structures and fields have been introduced to store validator information, including a Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (2)
- cmd/blobstream/query/cmd.go (8 hunks)
- rpc/app_querier.go (2 hunks)
Additional comments: 6
cmd/blobstream/query/cmd.go (6)
138-143: The addition of the
ValopAddressfield to thesignaturestruct aligns with the summary and enhances the data structure with more relevant information.146-150: The introduction of the
validatorInfostruct is a good encapsulation of validator details, which should improve code maintainability and clarity.242-257: The
toValidatorsInfofunction is correctly implemented to map staking validators tovalidatorInfoinstances, which is consistent with the summary.287-311: The update to the
toQueryOutputfunction to includeMonikerandValopAddressin thesignaturestruct is consistent with the summary and enhances the output with more detailed information.333-345: The modifications to the
printConfirmsfunction to displayMonikerandValopAddressin the log output are consistent with the summary and improve the visibility of these new details.284-311: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [9-345]
No issues found regarding error handling, data races, or performance in the provided hunks.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
==========================================
- Coverage 26.09% 25.91% -0.19%
==========================================
Files 29 29
Lines 3023 3044 +21
==========================================
Hits 789 789
- Misses 2139 2160 +21
Partials 95 95 ☔ View full report in Codecov by Sentry. |
# Conflicts: # cmd/blobstream/query/cmd.go
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- cmd/blobstream/query/cmd.go (8 hunks)
Additional comments: 6
cmd/blobstream/query/cmd.go (6)
15-22: The import of
stakingtypesand its usage in the code is correct and aligns with the summary provided.153-158: The addition of the
ValopAddressfield to thesignaturestruct is correctly implemented and matches the summary.161-164: The
validatorInfostruct is well-defined and serves the purpose of encapsulating validator details as described in the summary.257-272: The
toValidatorsInfofunction is correctly implemented to create a map ofvalidatorInfofrom the staking validators.302-326: The
toQueryOutputfunction has been modified appropriately to includevalidatorsInfoand populate thesignaturestruct withMonikerandValopAddress.348-360: The
printConfirmsfunction has been updated to display the newMonikerandValopAddressfields, which enhances the visibility of validator actions.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- cmd/blobstream/query/cmd.go (8 hunks)
Additional comments: 6
cmd/blobstream/query/cmd.go (6)
18-18: The import of
stakingtypesis correctly used in the newvalidatorInfostruct andtoValidatorsInfofunction.153-158: The addition of the
ValopAddressfield to thesignaturestruct is correctly implemented and used in thetoQueryOutputfunction.161-164: The new
validatorInfostruct is well-defined and serves its purpose within thetoValidatorsInfofunction.257-272: The
toValidatorsInfofunction is correctly implemented to create a map of validator information from the staking validators.302-326: The
toQueryOutputfunction has been modified appropriately to includevalidatorsInfoand populateMonikerandValopAddressfields in thesignaturestruct.348-360: The
printConfirmsfunction has been updated to logMonikerandValopAddressalongsideEvmAddress, which aligns with the summary of changes.
Overview
Checklist
Summary by CodeRabbit
New Features
Enhancements
Documentation