feat: support querying the number of orchestrator signatures for a nonces range #639
Conversation
rach-id
added
enhancement
WalkthroughThe Go codebase for Changes
Assessment against linked issues
Poem
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (1)
- cmd/blobstream/query/cmd.go (4 hunks)
Additional comments: 8
cmd/blobstream/query/cmd.go (8)
54-69: The
Signersfunction has been correctly updated to include subcommands for querying signers by nonce and range, which aligns with the PR objective.72-79: The
SignersNoncefunction has been updated to take a specific nonce as an argument, which is in line with the PR objective.136-184: The
startResourcesfunction has been updated to return additional resources necessary for the new querying capabilities, and the error handling approach has been modified.187-285: The
SignersRangefunction has been correctly added to query signers within a specified range of nonces, addressing the functionality requested in the linked issue.372-436: The
getSignaturesfunction has been updated to return aqueryOutputstruct, which likely encapsulates the results of the query in a structured format. The error handling within this function has also been altered.94-103: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [94-108]
The error handling and resource cleanup in the
SignersNoncefunction are implemented correctly, ensuring that all resources are properly released even in the event of an error.
208-221: The error handling and resource cleanup in the
SignersRangefunction are implemented correctly, ensuring that all resources are properly released even in the event of an error.334-347: The
validateRangefunction correctly checks for invalid range inputs, ensuring that the start nonce is less than the end nonce and neither are zero.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (1)
- cmd/blobstream/query/cmd.go (4 hunks)
Additional comments: 4
cmd/blobstream/query/cmd.go (4)
54-69: The
Signersfunction has been updated to include subcommands for querying by nonce and range, aligning with the PR objective to enhance querying capabilities.72-79: The
SignersNoncefunction correctly handles the new nonce argument, allowing for querying by a specific nonce or the latest nonce.136-184: The
startResourcesfunction has been updated to return additional resources and handle errors differently, which could affect resource management. Ensure that all dependent code is updated to handle these changes.187-193: The new
SignersRangefunction for querying a range of nonces has been added, which is a key feature requested in the PR objective.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
==========================================
- Coverage 25.91% 25.57% -0.35%
==========================================
Files 29 29
Lines 3044 3085 +41
==========================================
Hits 789 789
- Misses 2160 2201 +41
Partials 95 95 ☔ View full report in Codecov by Sentry. |
rach-id
changed the title
…nces range
Overview
Closes #629
Example output:
And also supports json outputs.
Checklist
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes