This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
chore: changes for golang ci lint to pass #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
changed the title
rach-id
changed the title
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 17.52% 17.52%
=======================================
Files 2 2
Lines 97 97
=======================================
Hits 17 17
Misses 79 79
Partials 1 1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evan-forbes
approved these changes
Jan 29, 2023
rach-id
added a commit
to rach-id/orchestrator-relayer
that referenced
this pull request
Jan 31, 2023
* chore: chore add nolint to parameters that will be used later * chore: chore add nolint to parameters that will be used later * chore: comment unused code for CI to pass * chore: rename commands for revive to pass
rach-id
added a commit
that referenced
this pull request
Jan 31, 2023
* feat: add base DHT implementation and test node * chore: rename test network to test DHT network * Update p2p/dht.go * Update p2p/dht.go * chore: rename DHTNetwork to TestDHTNetwork * ci: add markdown lint and run lint on PRs (#67) * ci: add markdown lint * ci: update lint to run on pull request * test: add dcc sign bytes test (#71) * test: add dcc sign bytes test * chore: rename byt to buf as suggested by @rahulghangas * ci: use go version 1.19 in lint (#68) * chore: changes for golang ci lint to pass (#80) * chore: chore add nolint to parameters that will be used later * chore: chore add nolint to parameters that will be used later * chore: comment unused code for CI to pass * chore: rename commands for revive to pass * chore(deps): bump goreleaser/goreleaser-action from 4.1.0 to 4.1.1 (#83) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci: update golang ci lint version (#82) * ci: only run `split-test-files` if go files change (#77) * feat: add copied relayer implementation (#84) * feat: add relayer implementation * chore: refactor relayer to have start and stop methods * chore(deps): bump actions/cache from 3.2.3 to 3.2.4 (#86) Bumps [actions/cache](https://github.com/actions/cache) from 3.2.3 to 3.2.4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3.2.3...v3.2.4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump goreleaser/goreleaser-action from 4.1.1 to 4.2.0 (#87) Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.1.1 to 4.2.0. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@v4.1.1...v4.2.0) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: update confirms types and adds marshallers/unmarshallers (#70) * feat: update confirms types and adds marshallers/unmarshallers * chore: fix conflicts * chore: go mod tidy * chore: increase the DHT sleep to 10ms --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Mainly comments a function that we will eventually use when we stick the QGB implementation together.
Checklist