-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
=======================================
Coverage 59.75% 59.75%
=======================================
Files 6 6
Lines 164 164
=======================================
Hits 98 98
Misses 53 53
Partials 13 13 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
wow, this is really cool! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! took a second look, and this makes sense to me so far. LGTM, utACK 👍 👍
will defer to @rahulghangas for final approval
CI will be fixed by: #101 |
# Conflicts: # go.sum
@rahulghangas Can you please check this so that I can open up new PRs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small comment (non blocking, can be merged without)
ChainID uint64 | ||
} | ||
|
||
func NewEVMChain(key *ecdsa.PrivateKey, chainID uint64) *EVMChain { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reduce future tech debt, can we add small doc comments for all exported functions and methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have docs for that in local. After this is merged, new PRs containing that will come. Thanks for flagging this
} | ||
} | ||
|
||
func (e *EVMChain) Close() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EVMChain *EVMChain | ||
} | ||
|
||
func NewTestNode(ctx context.Context, t *testing.T) *TestNode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
} | ||
|
||
func (tn TestNode) Close() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
Closes #55
Checklist