Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

feat: use evm address as key for confirms instead of orch addr #96

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Feb 2, 2023

Overview

Closes #89

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added the p2p p2p network related label Feb 2, 2023
@rach-id rach-id requested a review from rahulghangas February 2, 2023 10:56
@rach-id rach-id self-assigned this Feb 2, 2023
@rach-id rach-id requested a review from evan-forbes as a code owner February 2, 2023 10:56
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Merging #96 (d563b2c) into main (3d8a7cd) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   59.75%   59.75%           
=======================================
  Files           6        6           
  Lines         164      164           
=======================================
  Hits           98       98           
  Misses         53       53           
  Partials       13       13           
Impacted Files Coverage Δ
p2p/keys.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rach-id rach-id merged commit ab2fc4c into celestiaorg:main Feb 6, 2023
@rach-id rach-id deleted the use_evm_key_as_key branch February 6, 2023 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2p p2p network related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orchestrator address <> EVM address mapping
3 participants