Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable errcheck linter #204

Closed
rootulp opened this issue Jun 30, 2023 · 0 comments · Fixed by #208
Closed

Enable errcheck linter #204

rootulp opened this issue Jun 30, 2023 · 0 comments · Fixed by #208
Assignees
@rootulp

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jun 30, 2023 •
edited
Loading

Motivation

#202

Proposal

Run golangci-lint and specifically errcheck (enabled by default on golangci-lint)
@rootulp rootulp mentioned this issue Jun 30, 2023
Closed
@rootulp rootulp self-assigned this Jul 3, 2023
@rootulp rootulp mentioned this issue Jul 3, 2023
Merged
rootulp added a commit that referenced this issue Jul 4, 2023
@rootulp
feat!: enable golangci-lint (#208)
e8e042f 
Closes #204

Marked as breaking b/c the function signature for exported functions
(`RowRoots` and `ColRoots`) was modified to include an error return
parameter.

## Testing

1. `golangci-lint run` passes locally
2. `golangci-lint run` passes in CI
[here](https://github.com/celestiaorg/rsmt2d/actions/runs/5456354873/jobs/9929053344?pr=208#step:4:27)
0xchainlover pushed a commit to celestia-org/rsmt2d that referenced this issue Aug 1, 2024
@rootulp
feat!: enable golangci-lint (#208)
c2a76d2 
Closes celestiaorg/rsmt2d#204

Marked as breaking b/c the function signature for exported functions
(`RowRoots` and `ColRoots`) was modified to include an error return
parameter.

## Testing

1. `golangci-lint run` passes locally
2. `golangci-lint run` passes in CI
[here](https://github.com/celestiaorg/rsmt2d/actions/runs/5456354873/jobs/9929053344?pr=208#step:4:27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: enable golangci-lint rootulp/rsmt2d
1 participant
@rootulp