-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove test cases that vary based on codec for extendeddatacrossword_test.go #216
Comments
Thanks for opening this issue! |
I don't see any GH issues in this repo for adding new codecs. I think the current test structure is a byproduct of development (i.e. historically multiple codecs were supported) so IMO we should refactor to just support one codec. If we need to add a new codec in the future, the PR that adds a new codec can (and should) add test coverage for the new codec. |
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Closed: [#216](#216) <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Closed: [#216](celestiaorg/rsmt2d#216) <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
Context
The tests in extendeddatacrossword_test.go contain test cases for multiple codecs but after #151 this repo only supports one codec.
Example:
rsmt2d/extendeddatacrossword_test.go
Lines 24 to 31 in e8e042f
Proposal
Refactor the tests in this file to remove test cases that differ based on codec. This will likely remove a level of indentation from the interesting parts of this file.
The text was updated successfully, but these errors were encountered: