Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to choose underlying Merkle tree implementation #8

Closed
musalbas opened this issue Oct 29, 2020 · 2 comments
Closed

Allow user to choose underlying Merkle tree implementation #8

musalbas opened this issue Oct 29, 2020 · 2 comments

Comments

@musalbas
Copy link
Member

See celestiaorg/celestia-core#83 (comment)
@liamsi
Copy link
Member

liamsi commented Oct 29, 2020

This might imply that we need to change the API of the NMT to take in bytes instead of that namespace.Data interface: https://github.com/lazyledger/nmt/blob/1a5d9124ad10e40d0d743d7695e1983992089a2f/nmt.go#L236

@liamsi liamsi mentioned this issue Oct 30, 2020
Closed
liamsi added a commit that referenced this issue Oct 30, 2020
@liamsi
first stab on making the user choose a concrete tree #8
54642a7
@liamsi liamsi mentioned this issue Oct 30, 2020
Merged
liamsi added a commit that referenced this issue Dec 15, 2020
@liamsi
Merge pull request #9 from lazyledger/ismail/pluggable_tree
e5ec791 
enable the user to choose a concrete tree implementation #8
@liamsi
Copy link
Member

liamsi commented Dec 15, 2020

resolved in #9

@liamsi liamsi closed this as completed Dec 15, 2020
@liamsi liamsi mentioned this issue Jan 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@musalbas @liamsi