Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: codec typo #149

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix!: codec typo #149

merged 1 commit into from
Mar 13, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Mar 9, 2023

Closes #141

@rootulp rootulp requested review from musalbas and liamsi March 9, 2023 19:41
@rootulp rootulp self-assigned this Mar 9, 2023
Leopard = "Leopard"
RSGF8 = "RSFG8"
// RSGF8 stands for Reed-Solomon Galois Field 8-bit mode. This codec uses
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSGF8 stands for Reed-Solomon Galois Field 8-bit mode.

This was my best guess because I couldn't find a reference that explains this name.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #149 (a89c48b) into master (2348d8d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   81.60%   81.60%           
=======================================
  Files           8        8           
  Lines         560      560           
=======================================
  Hits          457      457           
  Misses         63       63           
  Partials       40       40           
Impacted Files Coverage Δ
codecs.go 50.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@musalbas
Copy link
Member

musalbas commented Mar 9, 2023

Tbh I think we can just remove support for infectious altogether

@rootulp rootulp merged commit 91acbb1 into celestiaorg:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo: RSFG8 => RSGF8
3 participants