Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary slice indexing #167

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jun 16, 2023

Closes #164

@rootulp rootulp requested a review from evan-forbes June 16, 2023 19:36
@rootulp rootulp self-assigned this Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #167 (5a7ba10) into master (6515446) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   81.43%   81.29%   -0.15%     
==========================================
  Files           7        7              
  Lines         528      524       -4     
==========================================
- Hits          430      426       -4     
  Misses         58       58              
  Partials       40       40              
Impacted Files Coverage Δ
extendeddatasquare.go 75.00% <100.00%> (-1.00%) ⬇️

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question on var naming, but otherwise LGTM

extendeddatasquare.go Show resolved Hide resolved
@rootulp rootulp requested a review from staheri14 June 16, 2023 22:37
@rootulp rootulp merged commit f166196 into celestiaorg:master Jun 19, 2023
@rootulp rootulp deleted the rp/drop-slice-indexing branch June 19, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary index calculation
3 participants