chore: check width in setRowSlice and setColSlice #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 81.43% 81.57% +0.13%
==========================================
Files 7 7
Lines 528 532 +4
==========================================
+ Hits 430 434 +4
Misses 58 58
Partials 40 40
|
evan-forbes
approved these changes
Jun 20, 2023
staheri14
approved these changes
Jun 23, 2023
| @@ -163,6 +166,9 @@ func (ds *dataSquare) setColSlice(x uint, y uint, newCol [][]byte) error { | |||
| return errors.New("invalid chunk size") | |||
| } | |||
| } | |||
| if x+uint(len(newCol)) > ds.width { | |||
| return fmt.Errorf("cannot set col slice at (%d, %d) of length %d: because it would exceed the data square width %d", x, y, len(newCol), ds.width) | |||
There was a problem hiding this comment.
Why the codecov still complains? As far as I can say, your tests cover this line 🤔
There was a problem hiding this comment.
idk, it look like the test does cover this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #169