Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove indexing into rebuiltExtendedShares #184

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jun 20, 2023

Closes #182

@rootulp rootulp requested a review from evan-forbes June 20, 2023 14:55
@rootulp rootulp self-assigned this Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #184 (f5fe518) into master (f166196) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   81.29%   81.26%   -0.04%     
==========================================
  Files           7        7              
  Lines         524      523       -1     
==========================================
- Hits          426      425       -1     
  Misses         58       58              
  Partials       40       40              
Impacted Files Coverage Δ
extendeddatacrossword.go 73.91% <100.00%> (-0.13%) ⬇️

extendeddatacrossword.go Show resolved Hide resolved
@rootulp rootulp requested a review from staheri14 June 22, 2023 17:44
@rootulp rootulp merged commit 21ac9ac into celestiaorg:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is indexing into the rebuiltExtendedShares necessary?
3 participants