Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidate conditionals #189

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jun 20, 2023

Closes #177

@rootulp rootulp self-assigned this Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #189 (61e60dd) into master (f166196) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   81.29%   81.22%   -0.08%     
==========================================
  Files           7        7              
  Lines         524      522       -2     
==========================================
- Hits          426      424       -2     
  Misses         58       58              
  Partials       40       40              
Impacted Files Coverage Δ
extendeddatacrossword.go 73.78% <100.00%> (-0.26%) ⬇️

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rootulp rootulp merged commit 328fe4d into celestiaorg:master Jun 21, 2023
@rootulp rootulp deleted the rp/consolidate-conditionals branch June 21, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Good coding practice
3 participants