add cell index to the Push method of Tree #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamsi
reviewed
Mar 26, 2021
liamsi
reviewed
Mar 27, 2021
tree.go
Outdated
| // pushed | ||
| type CellIndex struct { | ||
| AxisIndex uint | ||
| CellIndex uint |
There was a problem hiding this comment.
Is it on purpose that the type CellIndex contains a field with the same name as the type (CellIndex)?
There was a problem hiding this comment.
whoops, changed the type CellIndex -> SquareIndex, and dropped the Index of the fields. Happy to change it something else if anyone has ideas 1f35c00
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
Treeinterface to pass along the information needed to identify which cell is being pushed.closes #19