Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: return an error for RowRoots and ColRoots if EDS incomplete #213

Merged
merged 11 commits into from
Aug 4, 2023
Merged

feat: return an error for RowRoots and ColRoots if EDS incomplete #213

merged 11 commits into from
Aug 4, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 4, 2023 •
edited
Loading

Closes #122

@rootulp rootulp self-assigned this Jul 4, 2023
@rootulp
Merge branch 'master' into rp/row-roots-error
4571f63
@rootulp
wip: debuging strange error
4296489 
$ go test ./... -count=1
--- FAIL: TestCorruptedEdsReturnsErrByzantineData (0.00s)
    --- FAIL: TestCorruptedEdsReturnsErrByzantineData/Leopard (0.00s)
        --- FAIL: TestCorruptedEdsReturnsErrByzantineData/Leopard/corrupt_a_chunk_at_(0,_0)_and_delete_shares_from_the_rest_of_the_row (0.00s)
            extendeddatacrossword_test.go:240:
                	Error Trace:	extendeddatacrossword_test.go:240
                	Error:      	Should be in error chain:
                	            	expected: %!q(**rsmt2d.ErrByzantineData=0x140001a6168)
                	            	in chain: "bad root input: col 0 expected [14 173 204 9 46 43 83 239 196 173 233 206 109 179 29 23 121 147 201 151 214 107 242 198 161 183 94 44 31 50 75 167] got [27 215 198 42 199 154 136 130 121 67 148 175 29 217 179 44 44 3 207 83 212 164 182 216 17 54 168 138 186 78 147 102]"
                	Test:       	TestCorruptedEdsReturnsErrByzantineData/Leopard/corrupt_a_chunk_at_(0,_0)_and_delete_shares_from_the_rest_of_the_row
                	Messages:   	did not return a ErrByzantineData for a bad col or row
@rootulp
Copy link
Collaborator Author

rootulp commented Jul 5, 2023

Related: #220

@rootulp rootulp added the enhancement New feature or request label Aug 3, 2023
@rootulp rootulp marked this pull request as ready for review August 3, 2023 13:39
evan-forbes
evan-forbes approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

staheri14
staheri14 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rootulp rootulp merged commit 11678f4 into celestiaorg:main Aug 4, 2023
3 checks passed
@rootulp rootulp deleted the rp/row-roots-error branch August 4, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staheri14 staheri14 staheri14 approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

@musalbas musalbas Awaiting requested review from musalbas

Assignees

@rootulp rootulp

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expected behaviour of RowRoots() and ColRoots() on an incomplete EDS is undefined
3 participants
@rootulp @staheri14 @evan-forbes