docs: clarify rowRoots to Repair #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
=======================================
Coverage 77.96% 77.96%
=======================================
Files 7 7
Lines 531 531
=======================================
Hits 414 414
Misses 71 71
Partials 46 46
|
cmwaters
approved these changes
Jul 10, 2023
Comment on lines
+59
to
+62
| // Repair attempts to repair an incomplete extended data square (EDS). The | ||
| // parameters rowRoots and colRoots are the expected Merkle roots for each row | ||
| // and column. rowRoots and colRoots are used to verify that a repaired row or | ||
| // column is correct. Prior to the repair process, if a row or column is already |
There was a problem hiding this comment.
Q: you can technically repair an EDS without the rowRoots and colRoots right?
There was a problem hiding this comment.
Yes it is possible. I'm pretty confident it is because the underlying library (klauspost/reedsolomon) doesn't have a notion of verifying the repaired data against a row root or col root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #220