Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary conversions #282

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

estensen
Copy link
Contributor

No description provided.

Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the linter!

@@ -10,6 +10,7 @@ linters:
- nakedret
- revive
- prealloc
- unconvert
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8908c6c) 80.76% compared to head (9c972df) 80.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files           7        7           
  Lines         806      806           
=======================================
  Hits          651      651           
  Misses        112      112           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rootulp rootulp merged commit 406d2a5 into celestiaorg:main Jan 2, 2024
5 checks passed
@estensen estensen deleted the unconvert branch January 2, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants