fix: deepcopy filliing nil data with zeroes #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 80.89% 82.30% +1.40%
==========================================
Files 8 7 -1
Lines 869 616 -253
==========================================
- Hits 703 507 -196
+ Misses 119 66 -53
+ Partials 47 43 -4 ☔ View full report in Codecov by Sentry. |
|
The rust mind cannot comprehend this 😂 |
Wondertan
approved these changes
Apr 9, 2024
|
I wish golang had immutables too 🤝 |
rootulp
approved these changes
Apr 9, 2024
evan-forbes
approved these changes
Apr 10, 2024
Wondertan
pushed a commit
to celestiaorg/celestia-node
that referenced
this pull request
Apr 23, 2024
…struction (#3306) We should not restrict the BEFP constructor to collect proof only for orthogonal axes to ErrByzantine. This PR enables the constructor to attempt building both Row and Col proofs, irrespective of the ErrByzantine axis type. Additionally, it prevents the BEFP constructor from requesting proofs pr shars from the network by granting access exclusively to the local blockstore. There should be sufficient proofs and shares in the local blockstore at the time BEFP is detected. Breaks befp message, by introducing proofAxis field, which is not supported by older befp subscribers. Depends on - #3305 to have enough data in blockstore. - celestiaorg/rsmt2d#310 to provide proper coordinates of verified shares
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the bug introduced by #100. Currently, if
deepcopy()encounters nil inner slice values, it creates a slice of 0 length, which is incorrect. This PR addresses the issue. The problem becomes evident when eds is partially computed, resulting in Row() or Col() methods returning invalid copies.On the side note, it is technically breaking public API change. But the nature of the bug suggests noone relied on existing misbehaviour before.