improved sessionName + NewClient + InMemorySessionName #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fix this problem when I have a Pyrogram session as a string |
KoNekoD
changed the title
|
A couple more improvements would be just right :) |
celestix
requested changes
Sep 3, 2023
sessionMaker/sessionName.go
Outdated
| @@ -30,6 +30,8 @@ const ( | |||
| TelethonSession | |||
| // PyrogramSession is used as SessionType when you want to log in through the string session made by pyrogram - a Python MTProto library. | |||
| PyrogramSession | |||
| // InMemorySessionName is used when it is necessary to indicate that this session is in memory | |||
| InMemorySessionName = ":memory:" | |||
There was a problem hiding this comment.
Better to name this constant as "InMemorySession" instead of "InMemorySessionName", following the convention of library.
sessionMaker/sessionName.go
Outdated
| @@ -42,50 +44,88 @@ func NewSession(sessionName string, sessionType SessionType) *SessionName { | |||
| return &s | |||
| } | |||
|
|
|||
| func NewSessionWithoutFiles(sessionValue string, sessionType SessionType) *SessionName { | |||
There was a problem hiding this comment.
It would be better if you rename this function to NewInMemorySession() to avoid confusions and consider adding function documentations.
|
LGTM! |
|
Why lint failed? |
|
Thank you for the PR! We can resolve linting issues later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.