Ability to hide Info and Warning Messages as a User Setting #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tyler-lemke
commented
Feb 10, 2023
tyler-lemke
commented
- currently all or nothing, you hide all info, or all warning messages, or both
- hope to expand this later to allow the user to ignore specific types of info or warning messages, or even errors
Give the user the ability to hide info or warning type messages
Bump minimatch and mocha (celian-rib#29)
celian-rib
requested changes
Feb 11, 2023
Comment on lines
+135
to
+138
| // test('isHiddenMessage()', async () => { | ||
| // const result = IssueDiagnostic.isHiddenMessage(sampleWarningData.type); | ||
| // assert.strictEqual(result, true); | ||
| // }); |
There was a problem hiding this comment.
You should either uncomment or delete this test. :)
|
Nevermind I'll handle the cleanup :) thanks again ! |
|
Thanks. I shouldn't have let that sneak through! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.