Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyCelo: Complete migrations on #1362

Closed
trianglesphere opened this issue Feb 9, 2021 · 4 comments
Closed

MyCelo: Complete migrations on #1362

trianglesphere opened this issue Feb 9, 2021 · 4 comments
Assignees
Labels
theme: dev-productivity Whatever makes devs more productive (ci/testing/tooling)
Milestone

Comments

@trianglesphere
Copy link
Contributor

The ones left are attestations, validators, governance

@trianglesphere trianglesphere added blockchain theme: dev-productivity Whatever makes devs more productive (ci/testing/tooling) labels Feb 9, 2021
@oneeman
Copy link
Contributor

oneeman commented Feb 18, 2021

@trianglesphere @mcortesi One problem until this is done is that celocli network:contracts can't be used (it will exit with an error). For now I guess the way to go is to save the output of the genesis step, since it lists the contracts' addresses.

This may also be a blocker for #1383 and/or #1384. There may be ways to work around it, such as deploying those migrations separately after the testnet is running, but I'm guessing it'd be easier to just do this one first.

@oneeman oneeman self-assigned this Feb 23, 2021
@oneeman
Copy link
Contributor

oneeman commented Feb 23, 2021

Branch is https://github.com/celo-org/celo-blockchain/tree/oneeman/mycelo-missing-contracts . @mcortesi will do the 25_elect_validators migration

@mcortesi mcortesi added this to the Sprint 9.2 milestone Feb 24, 2021
@oneeman
Copy link
Contributor

oneeman commented Feb 25, 2021

@mcortesi I pushed the attestations and governance migrations. For governance, I skipped setting the constitution thresholds and transferring core contract ownership, as in all the existing configs in celo-monorepo we are skipping those steps. Adding the ownership transfer would be easy and quick if we want to later on. Support for a constitution would be more tedious. I'm going to reassign this issue to you as you're working on the ElectValidators migration.

@oneeman oneeman assigned mcortesi and unassigned oneeman Feb 25, 2021
@oneeman
Copy link
Contributor

oneeman commented Apr 28, 2021

This has already been finished in #1409

@oneeman oneeman closed this as completed Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: dev-productivity Whatever makes devs more productive (ci/testing/tooling)
Projects
None yet
Development

No branches or pull requests

3 participants