-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mycelo: Adds missing migrations & a few fixes #1409
Conversation
* Addition of StableTokenEUR and ExchangeEUR * New parameter to StableToken's initialize() signature * New parameter to Validators initialize() signature (grace period, CIP-29)
Both addresses were the same
Previous balance easily surpassed the 1billing CELO limit
I checked that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor comments here and there. Overall looks good.
common/token/token_test.go
Outdated
) | ||
|
||
func TestToString(t *testing.T) { | ||
RegisterTestingT(t) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs say RegisterTestingT
is deprecated and to use NewWithT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This is also used in places not touched by this PR)
Also, I noticed the failing lint, which is due to spelling. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! By the way, I will use this new decimal package to define another type with precision 1 (just a wrapper to serialize and deserialize big.Int
as strings in the gencodec overrides where needed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a lint, but lgtm
I added a commit fixing a bug when generating genesis with only one validator. |
Added another commit, fixing the developer accounts' cUSD balances which were in Wei rather than cUSD. Also merged master because github said there was a merge conflict (it was due to mycelo commands having moved to a separate file, easy to resolve). |
Description
This PR adds:
Other changes
Token
type that pretty prints token balances (18 decimals)genesis
commands to their own file.Tested
Run
mycelo
multiple times, check status and elections on epoch blocks, rewards distribution, etc.Related issues
Backwards compatibility
Yes