Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loadtest reporting flag to geth #1511

Closed
trianglesphere opened this issue Apr 15, 2021 · 0 comments · Fixed by #1516
Closed

Add loadtest reporting flag to geth #1511

trianglesphere opened this issue Apr 15, 2021 · 0 comments · Fixed by #1516
Assignees
@trianglesphere
Labels
theme: dev-productivity Whatever makes devs more productive (ci/testing/tooling) theme: scalability

Comments

@trianglesphere
Copy link
Contributor

Instead of requiring a modified version of geth to be present, add a flag that does the printing as needed.

Maybe also add in the metrics flags.
@trianglesphere trianglesphere added blockchain theme: dev-productivity Whatever makes devs more productive (ci/testing/tooling) theme: scalability labels Apr 15, 2021
@trianglesphere trianglesphere self-assigned this Apr 15, 2021
@trianglesphere trianglesphere mentioned this issue Apr 15, 2021
Merged
mergify bot pushed a commit that referenced this issue Apr 21, 2021
Add block production and consensus cycle metrics (#1516)
ede6fa2 
### Description

Adds better metrics for load testing.
Also adds a command line option `--metrics.loadtestcsvfile` to specify a file to write out information about the block production and consensus cycle in a CSV format. This was previously on a separate branch that was cherry-picked onto the branch that we wanted to loadtest.

### Tested

Local load test.

### Related issues

- Fixes #1511
oneeman pushed a commit that referenced this issue May 4, 2021
Add block production and consensus cycle metrics (#1516)
1d2bbd6 
### Description

Adds better metrics for load testing.
Also adds a command line option `--metrics.loadtestcsvfile` to specify a file to write out information about the block production and consensus cycle in a CSV format. This was previously on a separate branch that was cherry-picked onto the branch that we wanted to loadtest.

### Tested

Local load test.

### Related issues

- Fixes #1511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trianglesphere trianglesphere

Labels
theme: dev-productivity Whatever makes devs more productive (ci/testing/tooling) theme: scalability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add block production and consensus cycle metrics celo-org/celo-blockchain
1 participant
@trianglesphere