Mobile discovery improvements #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vor/mobile-disc-2020
nategraf
approved these changes
Aug 12, 2020
…vor/mobile-disc-2020
…vor/mobile-disc-2020
mergify bot
pushed a commit
to celo-org/celo-monorepo
that referenced
this pull request
Sep 2, 2020
### Description Should not be merged until valora-inc/react-native-geth#28 is merged (which itself relies upon celo-org/celo-blockchain#1132), and then the react-native-geth version in this PR will be updated. This uses the enodes that are used for static nodes as bootnodes for discovery. The current bootnodes that are deployed do not support the type of discovery required by mobile clients (discovery v5), but the static nodes do. Having more nodes as bootnodes will also help with discovery speed & diversity of the nodes discovered. When testing on baklava with both static nodes and discovery enabled, peering was nearly immediate. When only testing with discovery enabled and no static nodes, peering was very quick (< a few seconds). A few times I found when only relying upon discovery that no peers would be found, so I recommend keeping static nodes & discovery for the time being. ### Other changes I added some instructions on how to attach to the geth instance on the app. ### Tested Ran a lot on android & iOS devices ### Related issues ### Backwards compatibility Requires updates from react-native-geth (valora-inc/react-native-geth#28) and celo-blockchain (celo-org/celo-blockchain#1132) to work as intended
ewilz
pushed a commit
to ewilz/celo-monorepo
that referenced
this pull request
Sep 29, 2020
### Description Should not be merged until valora-inc/react-native-geth#28 is merged (which itself relies upon celo-org/celo-blockchain#1132), and then the react-native-geth version in this PR will be updated. This uses the enodes that are used for static nodes as bootnodes for discovery. The current bootnodes that are deployed do not support the type of discovery required by mobile clients (discovery v5), but the static nodes do. Having more nodes as bootnodes will also help with discovery speed & diversity of the nodes discovered. When testing on baklava with both static nodes and discovery enabled, peering was nearly immediate. When only testing with discovery enabled and no static nodes, peering was very quick (< a few seconds). A few times I found when only relying upon discovery that no peers would be found, so I recommend keeping static nodes & discovery for the time being. ### Other changes I added some instructions on how to attach to the geth instance on the app. ### Tested Ran a lot on android & iOS devices ### Related issues ### Backwards compatibility Requires updates from react-native-geth (valora-inc/react-native-geth#28) and celo-blockchain (celo-org/celo-blockchain#1132) to work as intended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a mobile app using mobile geth is closed entirely, it does not gracefully shut down. As a result, the server pool entries were not being properly persisted & loaded upon startup.
This PR:
les_serverPoolEntriesRPC to a new private LES client API to easily view server pool entriesOther changes
Looks like some go.mod/go.sum changes were made automatically, not sure if these are undesirable
I'm still testing this more but wanted to put the PR out
Tested
Ran on apps & peered more quickly when properly saving server pool entries
Related issues
Backwards compatibility
Backward compatible